yeah this is looking great! the only suggestion i have is to remove all of the commented out code.

Thanks @catarak - I've completed the changes for isEditingName too. Have also removed commented out code.

One question I had, which you can maybe advise on: Should I be binding the event handlers I've added to the FileNode component to this in the constructor for that?

This appears to work fine on my local installation and solves the problem of the needs saving mark not being removed.

Yes! The event handlers should be bound to this in the constructor. The reason for this is so that in the event handler, you can access the state of the React component (which is this). If you don't bind it, then I think by default this is the HTML element that the event handler is added to, though I'm not 100% sure on that.

@catarak - great! I actually did do that in the latest changes, so I think that means that this PR is complete and will leave it from you for here.

this looks great! i noticed a bug, which is if you rename a file, it doesn't save the sketch, or mark it as unsaved. i think that when you rename a file, the sketch should save.

@catarak Is this PR just waiting for a fix to this last bug?

[...] i noticed a bug, which is if you rename a file, it doesn't save the sketch, or mark it as unsaved. i think that when you rename a file, the sketch should save.

@bendman yes! feel free to pick up and fix. i don't think it makes sense to merge this in as it is now since the bug i found is a regression.

@catarak I'm working on this one now, but I'm not understanding how to reproduce the regressive bug. Right now on the live site I also see the bug where renaming a file doesn't save the sketch or mark it as unsaved.

This happens on the live site and this branch for me: If I rename a file, it doesn't save it or mark it as unsaved. If I reload the project, the file will have the original name.

The existing behavior is kind of weird though. Should I try to include a fix in this branch by saving the project once a file is renamed?

@bendman you're right! i think i was mixed up since when you change the sketch name, the sketch automatically saves, and now i'm wondering if that should be the same behavior for files, or if the sketch should set its state to having unsaved changes. i'll put this in a separate ticket.

let me take a second pass at this PR and see if there are any other changes to be made, otherwise i will actually merge it in.

just tested again, and this is working great. hopefully this also fixes #675. going to merge this!